Skip to content

fix: respect manual sub-pos by user during playback#381

Merged
Samillion merged 3 commits intomainfrom
dev_fix_respect_manual_sub_pos
Apr 29, 2025
Merged

fix: respect manual sub-pos by user during playback#381
Samillion merged 3 commits intomainfrom
dev_fix_respect_manual_sub_pos

Conversation

@Samillion
Copy link
Owner

@Samillion Samillion commented Apr 28, 2025

Fixes: #370

Changes

  • Respect manual sub-pos by user during playback all while maintaining show/hide osc sub rise.
  • Don't adjust subtitle position if user's sub-pos is higher (on screen) than the raise factor when osc is visible
  • Simplify scale logic into a variable

@Samillion Samillion merged commit ca64fd9 into main Apr 29, 2025
@Samillion Samillion deleted the dev_fix_respect_manual_sub_pos branch April 29, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect user's last sub-pos value

1 participant