Program: Resolve ~ as user home #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# treats ~ as directory in cwd, so you have to pass absolute path instead (like /home/user) Test: ./bin/Release/net9.0/linux-x64/Cpp2IL --game-path=~/Downloads/merged.apk Result: [Fail] [Program] Execution Failed: Could not find a valid unity game at /home/commonuserlol/projects/Cpp2IL/Cpp2IL/~/Downloads/merged.apk Result after fix: [Warn] [Program] No output format requested, so not outputting anything. The il2cpp game loaded properly though! Credit: https://stackoverflow.com/questions/4796254/relative-path-to-absolute-path-in-c
Pull Request Test Coverage Report for Build 12621675604Details
💛 - Coveralls |
Owner
|
This solution will break hard for any paths that have ~ in them anywhere other than the start, which is a valid character on windows and is somewhat common in Unity spaces because it's used as the "ignore this folder" character by the unity editor. |
SamboyCoding
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# treats
~as directory in cwd, so you have to pass absolute path instead (like/home/user)Test:
./bin/Release/net9.0/linux-x64/Cpp2IL --game-path=~/Downloads/merged.apkResult:
[Fail] [Program] Execution Failed: Could not find a valid unity game at /home/commonuserlol/projects/Cpp2IL/Cpp2IL/~/Downloads/merged.apkResult after fix:
[Warn] [Program] No output format requested, so not outputting anything. The il2cpp game loaded properly though!Credit: https://stackoverflow.com/questions/4796254/relative-path-to-absolute-path-in-c