ELF: Properly handle address outside of file-backed regions #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only cases where the virtual address is located outside of any ELF PHT entry are handled. However, since a PHT entry can also only be partially backed by file contents, this causes normally invalid address translations to succeed, which in turn leads to weird issues later on.
I've personally seen this cause issues with retrieving method pointers from Unity.Purchasing.AppleCore.dll on Android, where methodPointers points into .bss, but Cpp2IL still tries to read them from the file due to the entry containing the section being partially file-backed.