Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically refresh upstream and create Docker image #541

Closed
wants to merge 0 commits into from

Conversation

DavidHenryThoreau
Copy link

No description provided.

@DavidHenryThoreau
Copy link
Author

@SamR1 I'm working on docker images i'm looking at https://github.com/SamR1/FitTrackee/blob/master/db/create.sql , why do you drop database, if container restart it'll drop the DB.

I've also created a repository in order to build fittrackee-db https://github.com/DavidHenryThoreau/fittrackee-db add all steps in the Dockercompose.yaml f49fc18

@DavidHenryThoreau
Copy link
Author

TODO : Run ftcli db upgrade when fittrackee docker container starts in order to populate the databse

@DavidHenryThoreau
Copy link
Author

Images are built form source, need some testers :
docker compose pull && docker compose up -d

Have fun !

@DavidHenryThoreau
Copy link
Author

DavidHenryThoreau commented May 15, 2024

TODO :

docker python:3:10 image size : 1.46GB
docker python:3.10-slim image size : 902MB
docker python:3.10-alpineimage size : 737MB

  • Do not build PostgreSQL image (not necessary at the moment)

  • Add Redis alternative

@SamR1
Copy link
Owner

SamR1 commented May 15, 2024

Hi,

I'm working on docker images i'm looking at https://github.com/SamR1/FitTrackee/blob/master/db/create.sql , why do you drop database, if container restart it'll drop the DB.

The SQL script allows to recreate databases easily for tests during developpement.

About its execution (in docker-entrypoint-initdb.d):

Warning: scripts in /docker-entrypoint-initdb.d are only run if you start the container with a data directory that is empty; any pre-existing database will be left untouched on container startup.

source: https://hub.docker.com/_/postgres/

As I said in the other MR, docker files present in this repository are intended for evaluation or development only. So the configuration is not suitable for production. Other changes or steps may be necessary to secure deployment in production.

@DavidHenryThoreau
Copy link
Author

Hi,

I'm working on docker images i'm looking at https://github.com/SamR1/FitTrackee/blob/master/db/create.sql , why do you drop database, if container restart it'll drop the DB.

The SQL script allows to recreate databases easily for tests during developpement.

About its execution (in docker-entrypoint-initdb.d):

Warning: scripts in /docker-entrypoint-initdb.d are only run if you start the container with a data directory that is empty; any pre-existing database will be left untouched on container startup.

source: https://hub.docker.com/_/postgres/

Thanks for explanations

As I said in the other MR, docker files present in this repository are intended for evaluation or development only. So the configuration is not suitable for production. Other changes or steps may be necessary to secure deployment in production.

At the moment yes, but some users are waiting to use fittrackee in docker in production, that's why I'm working at it.
If all steps are green maybe you can merge to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants