-
Notifications
You must be signed in to change notification settings - Fork 0
Enumerate passing configurations in output #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerate passing configurations in output #19
Conversation
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
|
@copilot the formatting failed, if need be make sure agents.md is set up correctly with advice for running correct lint, test, format etc. we should never hit these issues in CI if instructions are good quality. |
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Fixed in commit 2b512da. The issue was that ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a feature to explicitly enumerate passing configurations in the output, addressing an issue where passing configurations were simply omitted, making it unclear whether they were tested or skipped.
Changes:
- Modified
generateMarkdownReport()andgeneratePRSummary()to explicitly list passing, changed, and error configurations in separate sections - Added comprehensive test coverage with 9 new tests covering all scenarios
- Updated compiled distribution file to match source changes
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/reporter.ts | Enhanced report generation to show passing configurations explicitly, separate changed configurations from errors, and organize output into clear sections |
| src/tests/reporter.test.ts | Added comprehensive test suite covering all scenarios: all passing, mixed passing/changed, error handling, and empty section behavior |
| dist/index.js | Updated compiled output matching source changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Plan to Enumerate Passing Configurations in Output
reporter.tsto show passing configurations explicitlyreporter.tsto list passing configurationsSummary
Successfully implemented the feature to enumerate passing configurations in output and fixed CI formatting issues.
Changes Made
1. Modified
src/reporter.tsgenerateMarkdownReport(): Added sections to explicitly list:generatePRSummary(): Similar updates to show all configuration statuses2. Created
src/__tests__/reporter.test.tsVerification
✅ All 50 tests pass
✅ Linting passes
✅ Type checking passes
✅ Formatting check passes (fixed)
✅ Build completes successfully
✅ Security scan passes (0 alerts)
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.