Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Plan to Enumerate Passing Configurations in Output

  • Understand the codebase and identify the issue
  • Update the markdown report in reporter.ts to show passing configurations explicitly
  • Update the PR summary in reporter.ts to list passing configurations
  • Add tests for the new output format
  • Verify changes by running tests
  • Run linting and type checking
  • Build the project
  • Address code review feedback
  • Run final code review and security checks
  • Fix code formatting issues

Summary

Successfully implemented the feature to enumerate passing configurations in output and fixed CI formatting issues.

Changes Made

1. Modified src/reporter.ts

  • generateMarkdownReport(): Added sections to explicitly list:
    • ✅ Passing configurations (no changes detected)
    • ⚠️ Configurations with changes
    • ❌ Configurations with errors
  • generatePRSummary(): Similar updates to show all configuration statuses
  • Error filtering: Fixed to properly exclude error configurations from the "changes" section
  • Formatting: Applied Prettier formatting (line breaks for long filter chains, removed trailing spaces)

2. Created src/__tests__/reporter.test.ts

  • Added 9 comprehensive tests covering all scenarios

Verification

✅ All 50 tests pass
✅ Linting passes
✅ Type checking passes
Formatting check passes (fixed)
✅ Build completes successfully
✅ Security scan passes (0 alerts)

Original prompt

This section details on the original issue you should resolve

<issue_title>Enumerate passing configurations in output</issue_title>
<issue_description>## Feature Request

Currently, when configurations pass (no diff detected), they are simply omitted from the output. This can make it unclear whether a configuration was actually tested or if it was skipped/failed silently.

Proposed Behavior

Explicitly list all configurations that passed, perhaps in a summary section like:

✅ Passing configurations (no changes detected):
  - default
  - read-only
  - toolsets-repos
  - toolsets-issues,context

⚠️ Configurations with changes:
  - toolsets-all (see diff below)

This would make it clear that:

  1. All expected configurations were actually tested
  2. Which ones had no changes (passing)
  3. Which ones had changes that need review

Benefits

  • Better visibility into test coverage
  • Easier to verify all configurations ran successfully
  • Clearer distinction between "no diff" and "didn't run"</issue_description>

<agent_instructions>So we do show passing configurations when everything is good, but as I understand it we omit them when there are diffs and only show the diffs. It would be good to do a bit better as this issue proposes.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 28, 2026 10:28
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Copilot AI changed the title [WIP] Add enumeration of passing configurations in output Enumerate passing configurations in output Jan 28, 2026
Copilot AI requested a review from SamMorrowDrums January 28, 2026 10:37
@SamMorrowDrums
Copy link
Owner

@copilot the formatting failed, if need be make sure agents.md is set up correctly with advice for running correct lint, test, format etc. we should never hit these issues in CI if instructions are good quality.

Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

@copilot the formatting failed, if need be make sure agents.md is set up correctly with advice for running correct lint, test, format etc. we should never hit these issues in CI if instructions are go...

Fixed in commit 2b512da. The issue was that src/reporter.ts had formatting violations (trailing spaces and long filter chains that should be broken into multiple lines). Ran npm run format to apply Prettier formatting. All checks now pass:

npm run format:check - passes
npm run lint - passes
npm run typecheck - passes
npm test - all 50 tests pass

@SamMorrowDrums SamMorrowDrums marked this pull request as ready for review January 28, 2026 15:18
Copilot AI review requested due to automatic review settings January 28, 2026 15:18
@SamMorrowDrums SamMorrowDrums merged commit 103bf95 into main Jan 28, 2026
10 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a feature to explicitly enumerate passing configurations in the output, addressing an issue where passing configurations were simply omitted, making it unclear whether they were tested or skipped.

Changes:

  • Modified generateMarkdownReport() and generatePRSummary() to explicitly list passing, changed, and error configurations in separate sections
  • Added comprehensive test coverage with 9 new tests covering all scenarios
  • Updated compiled distribution file to match source changes

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/reporter.ts Enhanced report generation to show passing configurations explicitly, separate changed configurations from errors, and organize output into clear sections
src/tests/reporter.test.ts Added comprehensive test suite covering all scenarios: all passing, mixed passing/changed, error handling, and empty section behavior
dist/index.js Updated compiled output matching source changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enumerate passing configurations in output

2 participants