Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from node12 to node16 #338

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Update from node12 to node16 #338

merged 1 commit into from
Dec 2, 2022

Conversation

the-snowwhite
Copy link
Contributor

Signed-off-by: the-snowwhite producer@holotronic.dk

#325
Based on actions-js/push#10

@the-snowwhite
Update from node12 to node16
84f6689 
Signed-off-by: the-snowwhite <producer@holotronic.dk>
@sammyskills
Copy link

Can someone please approve and merge this PR? The action keeps failing with the error below:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, SamKirkland/FTP-Deploy-Action@4.3.0

SamKirkland
SamKirkland approved these changes Dec 2, 2022
View reviewed changes
Copy link
Owner

@SamKirkland SamKirkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good merging, i'll have to publish a new version

@SamKirkland SamKirkland merged commit b8e4443 into SamKirkland:master Dec 2, 2022
@SamKirkland SamKirkland mentioned this pull request Dec 2, 2022
Closed
@sammyskills
Copy link

Thanks @SamKirkland , but it seems the issue is not fully resolved.

The error is still pointing to actions/checkout@v2

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2

@the-snowwhite the-snowwhite deleted the nodejs_update branch December 3, 2022 14:58
@Trainax Trainax mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickfl patrickfl patrickfl approved these changes

@SamKirkland SamKirkland SamKirkland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-snowwhite @sammyskills @SamKirkland @patrickfl