Repository navigation
docs(prior-art): dated citation check of every rules.yaml value - #217
Draft
obvious-autobuild[bot] wants to merge 1 commit into
Draft
obvious-autobuild[bot] wants to merge 1 commit into
obvious-autobuild[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
obvious-autobuild
Bot
force-pushed
the
obv/basescanning-024
branch
from
October 9, 2026 19:28
2fb9266 to
b02e44b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fleet-packet: basescanning-024
What changed
docs/04-prior-art-and-codes.mdgains a dated "Citation check" section: one row perserver/rules.yamlvalue (30 values, identical onmainandt3/server), each with the cited source, whether it is reachable, what it actually says, its edition or edit date, and a status. Nine values cite public sources; the rest cite repo documents or declare no source. The section ends with a Flagged list of citation mismatches and a link-check summary.git diffshows onlydocs/04(+58 lines);rules.yaml, schemas and server code are untouched.Why
Hunter asked for every public rule citation to be checked against its source: values, reachability, dates and mismatches, written up as a dated section, with link-check output and proposed changes for Sam and Hunter. The existing "Code citations" table stays as the summary; the new section is the dated audit behind it.
Verification
Checks completed 2026-10-09:
git diff main t3/server -- server/rules.yaml→ empty; both branches carry identical values, so one table covers both.npx --yes markdown-link-checkon the edited file with browser headers: 16 links checked, 11 fine, 5 flagged, all status 403 (Esri blog + four Roboflow Universe pages); without browser headers the two ICC pages were flagged as well. Each flagged page loads in a browser or through a crawler, so these are bot blocks, not dead links. Roboflow dataset sizes match the doc (402, 1.4k, 1.9k images).sourcestring inrules.yaml(30 values) has a row in the section; counted with a script against the file.Not verified: ICC code text on the cited ICC pages themselves (403 to automated access; secondary copies stand in, and the section says so). The safety framing of the values themselves: this audit checks citations, not whether any placement is safe or code-compliant, and the section opens with that line.
Proposed changes for Sam and Hunter
Values and code are unchanged; these are citation fixes for you to accept or decline.
clearances.ac_ft,clearances.battery_ft,facing.min_ft: say which help article (10280641) instead of "Base help page". The placement article (10280705) carries the gas 3 ft, the 20 ft meter distance and the 1 ft wall distance; the photo-checklist article carries the AC, fence and other-battery clearances.clearances.gas_ft: mark the Austin Energy and Texas Gas parts as meter-siting rules applied by analogy. Both put electric meters and outlets 3 ft from gas equipment; neither regulates battery placement.clearances.battery_ft: R328.3.1's exception is "large-scale fire testing" (the California-edition copy ties it to CFC 1207.1.5 rather than naming UL 9540A). Either quote the code or keep the paraphrase with a note.errors.drift_per_ft: label the p90s (8.2/22.3/60.1 in) as ARKit-vs-ARCore disagreement and note PR feat(evals): real-data evals for AR drift, wall reconstruction, coverage and the field test #12's position error against truth ran 2 to 3 times the allowance; replace "mostly ~7% scale error" with "5 to 17% short".errors.tape_ft: 0.05 ft rounds the stated half-inch resolution (0.0417 ft) up. Change the value or say it is rounded.Risk
Low: documentation only. The audit changes no values, no code and no schema; the flagged items list what Sam and Hunter may want to change next.
Checklist