Integration viewer: follow-ups from the #124 review (P2) #145

Activity

1. SamGu-NRX commented on Sep 27, 2026

   

   SamGu-NRX

   on Sep 27, 2026

   OwnerAuthor

   More actions

   The Codex review of 9c0680b, the final head of #124, raised no P1 and five P2s. They are recorded here instead of fixed, per the bounded-repair decision.

   • Status fields from a retired run. thread. A delayed status for a retired run no longer switches the run, but applyStatus still copies that response's status and filesRegistered before checking. It should reject the whole response when its runId is retired. This is the first one to take: it can mark the current run's running stages as unended and change when its result is read.
   • Retry-After on preview retries. thread. Preview retries use a fixed 5 s, and relayPreview does not pass Retry-After through from its own result or storage fetch.
   • A preview removed between reads. thread. A 404 preview_not_available from the relay should trigger a result re-read, as a 409 does, instead of retrying the preview.
   • The final count after a batch with no animation. thread. When an older landing timer is still pending and a newer batch cannot animate, the newest total is written only on the next state change. The last timer to fire should write the current counts.
   • The viewer suite in CI. thread. make check and CI do not run tools/integration-viewer. Adding them touches the root Makefile and a workflow, which needs the owners' agreement.