Repository navigation
fix: keep VS Code API types aligned with supported engine - #58
Conversation
Keep 1.90 as the minimum and prevent Dependabot from upgrading API typings independently of the engine.\n\nFixes #57\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesVS Code types version alignment
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to No concrete compatibility or update-policy issue remains in the reviewed changes, so they are ready to merge subject to normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The PR addresses [ ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #57.
engines.vscode: ^1.90.0remains required and unchanged. It admits compatible later 1.x releases, including the user-tested 1.140.0; it does not assert that all older versions were runtime-tested. The extension compiles against@types/vscode1.90.0, and the prior sandbox probe exercised its workspace APIs on 1.90.2. Limit API typings to~1.90.0and exclude independent minor/major type bumps from Dependabot so tooling cannot silently claim a higher minimum. Document the compatibility policy.Local verification:
npm ci,npm run lint,npm run build,npm test(151 passed, 1 skipped), and VSIX packaging with both lockedvsce3.9.2 and separately installedvsce4.0.0 pass.npm run test:integrationtimed out locally at the existing fixture CLI install/event test on a freshly downloaded VS Code 1.140.0; this is not a typecheck or packaging failure. CI must validate the integration test on each supported runner.Coordination with #56: its current branch explicitly changes
@types/vscodeto^1.138.0, so merging this PR alone does not make that stale grouped dependency branch safe. Regenerate/rebase #56 without the VS Code type bump after this lands, and require a green three-platform package + integration check before merging #56.Summary by CodeRabbit