Skip to content

Conversation

@hyunkeln
Copy link

Sometimes the grid isn't created ok, so I added a callback to invoke a function to correct the grid without resizing, I use as follows:

$('.element').responsiveEqualHeightGrid(function(){$(window).resize();});

Cheers!

@Sam152
Copy link
Owner

Sam152 commented Jan 23, 2015

The patch needs to check if "callback" is undefined for people who do not pass in the callback.

@hyunkeln
Copy link
Author

How about that?

@Sam152
Copy link
Owner

Sam152 commented Jan 28, 2015

Doesn't match coding standards for the rest of the project (need brackets around if statement, space after the "if", 4 space indentation)

"use strict" will throw an error due to non strict check, eg, need to use "!==".

Also, what is the difference between passing a callback in vs calling the plugin then calling a function straight after?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants