Skip to content

Use the Separator and SpinnerRing primitives instead of hand-made dividers and spinners #254

Open

Description

@Sall25

Today

Dividers. These draw their own line with a …divider / …separator class instead of Separator (src/components/tiptap-ui-primitive/separator):

  • features/workspace/workspace-switcher-popover.tsx (3)
  • features/shell/user-menu/user-menu.tsx
  • features/pages/share/share-panel/share-panel.tsx
  • features/auth/sign-in/sign-in.tsx (if it's the "or" line, keep it: it has text in it)
  • features/publish/published-page.tsx
  • features/database/ui/status/status-edit-display/status-edit-display.tsx
  • components/tiptap-ui/emoji-menu/emoji-list.tsx

(features/database/components/freeze-divider is a drag handle for frozen columns, not a divider: leave it.)

Spinners. These spin a LoaderCircle icon with their own CSS instead of SpinnerRing:

  • components/tiptap-node/audio-node/audio-node-view.tsx
  • components/tiptap-node/video-node/video-node-view.tsx
  • features/shell/offline/sync-status/sync-status.tsx (the "Saving…" pill)

What to do

Swap them, and delete the CSS that only drew the line or the spin. Check each in light and dark mode.

Done when

  • The listed dividers use Separator and the listed spinners use SpinnerRing, with their old CSS removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions