-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jen labels slds #226
Conversation
@davidhabib This PR fixes the number of contacts field rerender issue on the Send Bulk Email page. It also has the fix to the issue you saw in the namespaced org with the batch page not updating. The New And Edit VRS page has also been sldsified and as a reminder please take a look at the Contact resetting when a JRS is chosen. |
@davidhabib this is ready again. Thanks! |
<h3 class="slds-section-title slds-text-align--left">{!$Label.labelCopySchedule}</h3> | ||
<apex:outputPanel id="jrs"> | ||
<div class="slds-form-element slds-p-bottom--large slds-p-top--small slds-size--1-of-2"> | ||
<apex:actionRegion > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i figured out why we lose contactId when we do the copy from JRS. the actionSupport for it is within this actionRegion, so that only the value of slJRS gets shipped to the server. Thus contact isn't preserved. But we explicitly do this, so none of the required fields in the lower section generate errors when trying to copy with the JRS. I think we can live with this issue. No one has ever complained, and it is less likely, not that the copy JRS is at the top of the page.
Critical Changes
Changes
Issues Closed
Fixes #224