Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Generated Projects Failing Tests @@W-17978989@@ #2305

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bendvc
Copy link
Collaborator

@bendvc bendvc commented Mar 7, 2025

Description

If you generated a retail react app project NOT using extensibility and attempt to run the tests locally you'l be faced with a bunch of errors. This primarily due to dependancy versions marching on and some of our tests not playing ball with those updates. The PR has a bunch of small changes to ensure that the projects tests don't fail. This include but isn't limited to pinning the version of the user events testing library.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • Coming soon..

@bendvc bendvc requested a review from a team as a code owner March 7, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant