Skip to content

fix: vs extension lint error#158

Open
patricksullivansf wants to merge 4 commits intomainfrom
psullivan.vsExtFixLintDep
Open

fix: vs extension lint error#158
patricksullivansf wants to merge 4 commits intomainfrom
psullivan.vsExtFixLintDep

Conversation

@patricksullivansf
Copy link
Contributor

@patricksullivansf patricksullivansf commented Feb 16, 2026

Summary

Fixes lint error

% pnpm lint
...
packages/b2c-vs-extension lint$ eslint
...
│ A configuration object specifies rule "@typescript-eslint/no-unused-vars", but could not find plugin "@typescript-eslint".
  • update lint configuration
  • always run lint as part of test
  • reformat files so linting passes
  • added vs extension linting to CI (assuming testing can't be done on CI since it launches vscode)

Testing

Start with a fresh clone, run pnpm install, pnpm lint
Or pnpm install, pnpm test

Dependencies

  • No net-new third-party dependencies were added
  • If net-new third-party dependencies were added, rationale/discussion is included and 3pl-approved is set by a maintainer

  • Tests pass (pnpm test)
  • Code is formatted (pnpm run format)

@wei-liu-sf
Copy link
Collaborator

can you add pnpm lint as one of PR requirements in PR template?

@patricksullivansf
Copy link
Contributor Author

can you add pnpm lint as one of PR requirements in PR template?

Added "posttest": "pnpm run lint" to vs ext project.json, which should be consistent with other projects. (pnpm test is already in the template).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants