Add build-image Makefile target and build version support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dtroyer-salad
commented
Nov 1, 2023
•
dtroyer-salad
commented
- Use the commit for BUILD_VERSION since we do not tag the repo
- Use the commit date rather than build date to provide a bit of ordering to the builds
dtroyer-salad
force-pushed
the
make2
branch
5 times, most recently
from
d9ad2ec
to
3ee3fcb
Compare
* Use the commit for BUILD_VERSION since we do not tag the repo * Use the commit date rather than build date to provide a bit of ordering to the builds Signed-off-by: Dean Troyer <dean.troyer@salad.com>
|
This replaces the older PR with Makefile updates, I've removed the runtime stuff, will capture that in the demo support bits. |
lechgu
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.