fix: show_signature now ignores trigger.enabled if called directly #1946
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current State - Calling
show_signature()
whensignature.enabled = true
butsignature.trigger.enabled = false
prevents the signature popup from showing at all.Expected State - Calling
show_signature()
directly (similar toshow()
) should ignore thesignature.trigger.enabled
flagChange - Add a force opt to match
show()
that bypasses thesignature.trigger.enabled
flag