Skip to content

fix: show_signature now ignores trigger.enabled if called directly #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dladukedev
Copy link

Current State - Calling show_signature() when signature.enabled = true but signature.trigger.enabled = false prevents the signature popup from showing at all.

Expected State - Calling show_signature() directly (similar to show()) should ignore the signature.trigger.enabled flag

Change - Add a force opt to match show() that bypasses the signature.trigger.enabled flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant