Skip to content

fix(window): clear docs popup when menu updates to prevent stale items #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soifou
Copy link
Collaborator

@soifou soifou commented Jun 21, 2025

Problem: documentation popup could stick around and leave "dead" window on screen when the menu updates completion items.

Solution: ensures the doc window closes when the menu updates.

Closes #1932

Problem: documentation popup could stick around and leave "dead"
window on screen when the menu updates completion items.

Solution: ensures the doc window closes when the menu updates.

Closes #1932
@soifou soifou force-pushed the fix/window-docs branch from a543108 to c8924cf Compare June 21, 2025 12:15
@Saghen
Copy link
Owner

Saghen commented Jun 24, 2025

We'll close the documentation if the menu closes here:

menu.close_emitter:on(function() docs.close() end)

From the attached video in #1932, it looks like the menu is sticking around but only the bottom half of it. Maybe there's a weird rendering bug happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion menu render doesn't get cleared
2 participants