Avoid choose ZeroTier's tap to defaultInterface #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekohasekai
requested changes
Nov 3, 2022
|
|
||
| // zeroTierFakeGatewayIp from | ||
| // https://github.com/zerotier/ZeroTierOne/blob/1.8.6/osdep/WindowsEthernetTap.cpp#L994 | ||
| var zeroTierFakeGatewayIp = netip.MustParseAddr("25.255.255.254") |
There was a problem hiding this comment.
It is better to use a more general check.
nekohasekai
force-pushed
the
dev
branch
20 times, most recently
from
9be711a to
ca53ccf
Compare
nekohasekai
force-pushed
the
dev
branch
4 times, most recently
from
db67add to
8bf4113
Compare
nekohasekai
force-pushed
the
dev
branch
3 times, most recently
from
6769085 to
a8bd392
Compare
nekohasekai
force-pushed
the
dev
branch
3 times, most recently
from
72899fc to
0310956
Compare
nekohasekai
force-pushed
the
dev
branch
21 times, most recently
from
7708e65 to
737ebf0
Compare
nekohasekai
force-pushed
the
dev
branch
4 times, most recently
from
ea359a0 to
e8d7fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.