Avoid choose ZeroTier's tap to defaultInterface #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekohasekai
requested changes
Nov 3, 2022
| @@ -10,6 +11,10 @@ import ( | |||
| "golang.org/x/sys/windows" | |||
| ) | |||
|
|
|||
| // zeroTierFakeGatewayIp from | |||
| // https://github.com/zerotier/ZeroTierOne/blob/1.8.6/osdep/WindowsEthernetTap.cpp#L994 | |||
| var zeroTierFakeGatewayIp = netip.MustParseAddr("25.255.255.254") | |||
There was a problem hiding this comment.
It is better to use a more general check.
nekohasekai
force-pushed
the
dev
branch
20 times, most recently
from
9be711a to
ca53ccf
Compare
nekohasekai
force-pushed
the
dev
branch
4 times, most recently
from
db67add to
8bf4113
Compare
nekohasekai
force-pushed
the
dev
branch
3 times, most recently
from
6769085 to
a8bd392
Compare
nekohasekai
force-pushed
the
dev
branch
8 times, most recently
from
de8aa04 to
85f5f2d
Compare
nekohasekai
force-pushed
the
dev
branch
3 times, most recently
from
1f04328 to
aecfc19
Compare
nekohasekai
force-pushed
the
dev
branch
2 times, most recently
from
49977c4 to
f845cff
Compare
nekohasekai
force-pushed
the
dev
branch
2 times, most recently
from
ac77bdc to
69ee7ba
Compare
nekohasekai
force-pushed
the
dev
branch
2 times, most recently
from
0353283 to
9ae4518
Compare
nekohasekai
force-pushed
the
dev
branch
5 times, most recently
from
821737f to
5a91eb9
Compare
nekohasekai
force-pushed
the
dev
branch
4 times, most recently
from
858d089 to
6a7c403
Compare
nekohasekai
force-pushed
the
dev
branch
2 times, most recently
from
d2206e7 to
d0887ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.