Repository navigation
Aa: an Off detent, so 1× is not both "leave my window" and a fit (#179) - #181
Open
ArfiArfath21 wants to merge 1 commit into
Open
ArfiArfath21 wants to merge 1 commit into
ArfiArfath21 wants to merge 1 commit into
Conversation
…fsanity#179) With no scale the host leaves the Mac window alone, but the control showed that state as 1×, the same as a fit at 1×, and nothing took a device back to it short of disconnecting. The ruler gets an Off detent one step below 0.5×, which an untouched Aa now shows. Choosing it sends no scale, and the host puts the windows it sized back at once, for the connection that had fitted them (another device's viewport without a scale ends nobody's fit). With the virtual display on, no scale means 1× there, so the control does not offer Off. TextScale is pure and in the protocol check, with eight mutants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179.
With no scale the host leaves the Mac window alone. The Aa control showed that state as 1×, the same as a fit at 1×, so once Aa had been touched nothing took a device back to "leave my window", and each selection shrank the window again until the person disconnected (the reporter's workaround).
What it does
restoreFits, the path a window takes when it stops streaming), instead of at the end of the session. It is tracked per connection (fitScales), so another device's viewport without a scale ends nobody's fit.offered, from the Mac's setting as the device knows it).TextScale(new,Sources/StreamProtocol, so no project-file entry) holds the detents, snapping, titles and the "ends a fit" rule; the oldTextScaleControl.snapand its detent list moved into it, andTextScaleControl.labelstill exists. 18 new checks in theprotocolcheck, 8 mutants, all caught.Tests/checks/README.mdanddocs/DEVELOPMENT.md(Windows sized for a device) say so.For review
StreamCoordinator.swift, the.viewportcase: the restore happens beforeviewportis updated. Worth a look next to yourfit-by-defaultbranch and Could Sill scale apps while not using Virtual Display mode #70, which also touch when windows are fitted.restoreFits(keeping: nil), which also puts back a window that is streaming now; the catalog's size check then restarts the pipeline, as for any resize.Verified, and not
Tests/checks/run-all.sh protocolpasses (210 checks) and its eight new mutants are caught.swift build -c release --product SillHostbuilds. The iOS target type-checks with my Xcode 26.6 apart from the errormainalready has (DeviceHingeContextinDuoPostureReader.swift, which needs the 27.1 SDK).AI assistance: this change was written by an AI coding assistant (Claude) at my direction. I reviewed the diff and ran the checks above.