Repository navigation
Conversation
…ting (Saffsanity#113) WindowStrip's hold duration was fixed at 1.5 s (three times iOS's 0.5 s standard). ThumbnailHold lowers the default to 0.5 s and offers 0.5 s, 1 s, 1.5 s, 2 s and 3 s in Settings › This iPad / This iPhone (Sill.thumbnailHold), updated live on HoldDragOverlay's recognizer (gestures: 158 checks, 48 of 48 mutants).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113.
What it does
Lowers the window thumbnail long-press duration in
WindowStripfrom 1.5 s to 0.5 s by default (matchingUILongPressGestureRecognizer's standard 0.5 s duration) and adds a Thumbnail Hold picker (0.5 s,1 s,1.5 s,2 s,3 s) in Settings › This iPad / This iPhone (Sill.thumbnailHold). Device only: no wire change, nothing sent to the Mac.HoldDragOverlay.updateUIViewupdateshold.minimumPressDurationin place when the setting changes so existing thumbnails in the bar follow the new duration immediately.Why
Holding a window thumbnail in the bar to open its Close, Minimize and Full Screen lights or drag it to a new slot required a 1.5 s press, three times iOS's standard 0.5 s long-press duration, which made the press feel unresponsive while also risking accidental triggers for users who prefer a longer hold. Making 0.5 s the default with 1–3 s options lets either preference work.
Checks
Tests/checks/gestures: 158 checks (2 new forThumbnailHolddefault, fallback, ascending durations and titles). 48 of 48 mutants caught (3 new). Updated the checks README.swift build -c releaseand the iOS simulator build pass with only the known warnings.