Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

feat: filter modules, classes, functions, and parameters #156

Merged
merged 10 commits into from
Jul 22, 2021
Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jul 22, 2021

Closes #7.

Summary of Changes

  • Filter box in the menu bar.
  • Expected input has the form <scope>:<filterString>, where scope is one of module, class, function, or parameter and filterString is an arbitrary string. Each scope must occur at most once.
  • The filterString must occur anywhere in the name of the declaration for it to be matched. This means module:neighbors would match sklearn.neighbors._kde, for example.
  • Search is case-insensitive.
  • When the class filter is active, all top-level functions are removed.
  • When any filter is active, nodes in the tree view without children are removed.

Screenshots

image

image

Testing instructions

  • Try the following queries and vary them:
    • module:neighbors
    • class:transformer
    • function:fit
    • parameter:y
  • Check that the original view is reinstantiated when the filters are removed

@lars-reimann lars-reimann changed the title Filter feat: filter modules, classes, functions, and parameters Jul 22, 2021
@paul0314 paul0314 self-assigned this Jul 22, 2021
Copy link
Contributor

@paul0314 paul0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nach der Eingabe "parameter:WhateverTest" werden nur vereinzelt Module entfernt und weiterhin Parameter angezeigt, die nicht den String "WhateverTest" enthalten.

image

@lars-reimann lars-reimann requested a review from paul0314 July 22, 2021 17:37
Copy link
Contributor

@paul0314 paul0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Frage mich nur, ob es beabsichtigt ist, dass die Datei empty.json zum Projekt hinzugefügt wird? Falls ja merge es gerne rein.

@lars-reimann lars-reimann merged commit 749e7db into master Jul 22, 2021
@lars-reimann lars-reimann deleted the filter branch July 22, 2021 18:02
@lars-reimann
Copy link
Member Author

lars-reimann commented Jul 22, 2021

Habe ich erstmal mir reingepackt, damit wir eine weitere Datei zum Testen haben, insbesondere für diesen Edge-Case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suche / Filter
2 participants