This repository was archived by the owner on Jan 19, 2025. It is now read-only.
ci: remove merge queue workflows #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #1280 +/- ##
=======================================
Coverage 66.40% 66.40%
=======================================
Files 168 168
Lines 7188 7188
Branches 596 596
=======================================
Hits 4773 4773
Misses 2146 2146
Partials 269 269
|
lars-reimann
added a commit
to Safe-DS/Datasets
that referenced
this pull request
Mar 16, 2023
### Summary of Changes * Remove merge queue workflows (see Safe-DS/API-Editor#1280) * Add required workflows (see Safe-DS/API-Editor#1279)
lars-reimann
added a commit
to Safe-DS/Library
that referenced
this pull request
Mar 16, 2023
### Summary of Changes * Remove merge queue workflows (see Safe-DS/API-Editor#1280) * Add required workflows (see Safe-DS/API-Editor#1279)
lars-reimann
added a commit
to Safe-DS/DSL
that referenced
this pull request
Mar 16, 2023
### Summary of Changes * Remove merge queue workflows (see Safe-DS/API-Editor#1280) * Add required workflows (see Safe-DS/API-Editor#1279)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We have some checks that should be a requirement before PRs can be added to a merge queue:
Naturally, the code should also build. In the merge queue itself, we only need to verify again that the code still builds as previous PRs get merged in. Checking the title of the PR again, for example, is a waste of time since it cannot have changed.
However, this cannot be realized since checks that are marked as required must be run in the merge queue and on pull request events.
Conclusion: With our current throughput, a merge queue just slows us down.
See also this discussion.