Skip to content

Commit

Permalink
Restrict engines:node to >=12, <15, Update apollo-server-core to 2.25.3
Browse files Browse the repository at this point in the history
This brings `apollo-server-core` up to the latest released version and restricts this version of the integration to have the same Node engine support as the 2.x branch of Apollo.

This is due to the fact that batch requests no longer run in parallel in Node 16 and the code that handles that is outside the scope of this package. If the Apollo team adds Node 16 support to the v2 branch, then I can update dependencies to enable support as well, but until then I can't do anything about it.

Vercel at this time only supports two environments anyways, Node 12 and 14.

Node 16 support will be added in a new major version, along with an update to Apollo Server 3.x
  • Loading branch information
Saeris committed Nov 27, 2021
1 parent ec61ad8 commit d1f415f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [12, 14, 16]
node-version: [12, 14]

steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"main": "src/index.js",
"engines": {
"node": ">=12"
"node": ">=12 <15"
},
"scripts": {
"ci": "yarn install --ignore-scripts --frozen-lockfile --silent --non-interactive",
Expand All @@ -44,7 +44,7 @@
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.29",
"@vercel/node": "^1.12.1",
"apollo-server-core": "^2.16.1"
"apollo-server-core": "2.25.3"
},
"devDependencies": {
"@babel/core": "^7.16.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2160,7 +2160,7 @@ apollo-server-caching@^0.7.0:
dependencies:
lru-cache "^6.0.0"

apollo-server-core@^2.16.1:
apollo-server-core@2.25.3:
version "2.25.3"
resolved "https://registry.yarnpkg.com/apollo-server-core/-/apollo-server-core-2.25.3.tgz#1a649fd14b3928f5b6e65f0002b380fcfde56862"
integrity sha512-Midow3uZoJ9TjFNeCNSiWElTVZlvmB7G7tG6PPoxIR9Px90/v16Q6EzunDIO0rTJHRC3+yCwZkwtf8w2AcP0sA==
Expand Down

0 comments on commit d1f415f

Please sign in to comment.