-
Notifications
You must be signed in to change notification settings - Fork 14
Improve detection for cd/dvd-cops version string #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve detection for cd/dvd-cops version string #368
Conversation
Just because they're in Redump entries doesn't mean that it's been reported or confirmed here in this project. There's no broader plans for a version table or anything of the sort. |
}, GetVersion, "CD-Cops"), | ||
}, GetVersion, "CD-Cops (Unconfirmed - Please report to us on Github)"), | ||
|
||
// DVD-Cops, ver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this at the bottom to make it more apparent that it's the string version of the byte array.
Implemented all of those. I also noticed and added one last thing, a check for Codefree. Let me know if there are any issues with that. For my own documentation:
Edit: attached samples for anyone else who might need them, let me know if these need to be removed. |
This removes the content check, moves the NE checks to the NE check section, and adds a PE check for the single currently confirmed section.
One thing I was wondering- what's with the "(Unconfirmed - Please report to us on Github)" parts? They seem pretty confirmed, even being in existing redump entries. Is it supposed to be a placeholder for a safedisc-style version table?
Fixes #367