Skip to content

Improve detection for cd/dvd-cops version string #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

HeroponRikiBestest
Copy link
Contributor

@HeroponRikiBestest HeroponRikiBestest commented May 13, 2025

This removes the content check, moves the NE checks to the NE check section, and adds a PE check for the single currently confirmed section.

One thing I was wondering- what's with the "(Unconfirmed - Please report to us on Github)" parts? They seem pretty confirmed, even being in existing redump entries. Is it supposed to be a placeholder for a safedisc-style version table?

/home/bestest/cdCopsSamples/2002MM/BMM.exe: DVD-Cops (Unconfirmed - Please report to us on Github) 2.01
/home/bestest/cdCopsSamples/2003MM/bmm.exe: DVD-Cops (Unconfirmed - Please report to us on Github) 1,60
/home/bestest/cdCopsSamples/aHugEu/AgentHugo.exe: CD-Cops (Unconfirmed - Please report to us on Github) 1,08
/home/bestest/cdCopsSamples/bib/bib.dll: CD-Cops 1.95
/home/bestest/cdCopsSamples/mofamen/h3blade.exe: CD-Cops (Unconfirmed - Please report to us on Github) 1.72

Fixes #367

@mnadareski
Copy link
Collaborator

One thing I was wondering- what's with the "(Unconfirmed - Please report to us on Github)" parts? They seem pretty confirmed, even being in existing redump entries. Is it supposed to be a placeholder for a safedisc-style version table?

Just because they're in Redump entries doesn't mean that it's been reported or confirmed here in this project. There's no broader plans for a version table or anything of the sort.

}, GetVersion, "CD-Cops"),
}, GetVersion, "CD-Cops (Unconfirmed - Please report to us on Github)"),

// DVD-Cops, ver.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this at the bottom to make it more apparent that it's the string version of the byte array.

@HeroponRikiBestest
Copy link
Contributor Author

HeroponRikiBestest commented May 13, 2025

Implemented all of those. I also noticed and added one last thing, a check for Codefree. Let me know if there are any issues with that.

For my own documentation:

/home/bestest/cdCopsSamples: CD/DVD-Cops, CD/DVD-Cops, CD-Cops, CD-Cops Codefree
/home/bestest/cdCopsSamples/2002MM/BMM.exe: DVD-Cops 2.01
/home/bestest/cdCopsSamples/2003MM/bmm.exe: DVD-Cops 1,60
/home/bestest/cdCopsSamples/aHugEu/AGENTHUG.QZ_: CD/DVD/WEB-Cops, CD/DVD-Cops, PEtite
/home/bestest/cdCopsSamples/aHugEu/AgentHugo.exe: CD-Cops 1,08
/home/bestest/cdCopsSamples/aHugEu/AGENTHUGO.W_X: CD/DVD-Cops, RenderWare
/home/bestest/cdCopsSamples/aHugEu/cdcode.key: CD-Cops Codefree
/home/bestest/cdCopsSamples/aHugEu/CDCOPS.DLL: CD-Cops, CD-Cops
/home/bestest/cdCopsSamples/bib/bib.dll: CD-Cops 1.95
/home/bestest/cdCopsSamples/flap/cdcode.key: CD-Cops Codefree
/home/bestest/cdCopsSamples/flap/CDCOPS.DLL: CD-Cops, CD-Cops
/home/bestest/cdCopsSamples/flap/FGP.exe: CD-Cops 1,31
/home/bestest/cdCopsSamples/flap/FGP.QZ_: CD/DVD/WEB-Cops, CD/DVD-Cops, PEtite
/home/bestest/cdCopsSamples/flap/FGP.W_X: CD/DVD-Cops
/home/bestest/cdCopsSamples/mofamen/h3blade.exe: CD-Cops 1.72
/home/bestest/cdCopsSamples/roboRum/cdcode.key: CD-Cops Codefree
/home/bestest/cdCopsSamples/roboRum/CDCOPS.DLL: CD-Cops, CD-Cops
/home/bestest/cdCopsSamples/roboRum/ROBORUMB.QZ_: CD/DVD/WEB-Cops, CD/DVD-Cops, PEtite
/home/bestest/cdCopsSamples/roboRum/RoboRumble.exe: UNI-Cops
/home/bestest/cdCopsSamples/roboRum/RoboRumble.W_X: CD/DVD-Cops, RenderWare

Edit: attached samples for anyone else who might need them, let me know if these need to be removed.
cdCopsSamples.zip

@mnadareski mnadareski merged commit af43748 into SabreTools:master May 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steps to remove(?) cd/dvd-cops content check
2 participants