Uncaught exception in polls: TypeError: Cannot read properties of undefined (reading 'org.matrix.msc1767.text')

[bartoostveen]

Describe the bug

When opening a poll on a version of Sable that has poll support, you can observe this error. The app entirely crashes because of an unhandled exception.

TypeError: Cannot read properties of undefined (reading 'org.matrix.msc1767.text')
    at https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:99319:45
    at jA (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:5328:156)
    at n$ (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:5959:28)
    at B$ (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:7892:90)
    at T$ (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:7590:15)
    at Y_e (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:7584:29)
    at gx (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:7574:11)
    at n7 (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:7362:83)
    at S$ (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:7407:32)
    at Qh (https://matrix.bartoostveen.nl/assets/index-Byoxqa5U.js:4722:19)

The problematic code is probably here. It is generally a good idea to not assert that certain values exist in these events, but I am not sure where exactly this is going wrong
https://github.com/SableClient/Sable/blob/dev/src/app/components/message/PollEvent.tsx

Reproduction

On Sable 1.18.3, try to open a room which contains a problematic event, and observe the crash. Example of such a problematic event:

{
  "content": {
    "org.matrix.msc1767.text": "foo bar",
    "org.matrix.msc3381.poll.start": {
      "answers": [
        {
          "id": "1",
          "org.matrix.msc1767.text": "1"
        },
        {
          "id": "2",
          "org.matrix.msc1767.text": "2"
        },
        {
          "id": "3",
          "org.matrix.msc1767.text": "3"
        },
        {
          "id": "4",
          "org.matrix.msc1767.text": "4"
        },
        {
          "id": "5",
          "org.matrix.msc1767.text": "5"
        },
        {
          "id": "6",
          "org.matrix.msc1767.text": "6"
        },
        {
          "id": "7",
          "org.matrix.msc1767.text": "7"
        },
        {
          "id": "8",
          "org.matrix.msc1767.text": "8"
        },
        {
          "id": "9",
          "org.matrix.msc1767.text": "9"
        },
        {
          "id": "10",
          "org.matrix.msc1767.text": "10"
        }
      ],
      "kind": "org.matrix.msc3381.poll.disclosed",
      "max_selections": 1,
      "question": {
        "body": "foo bar",
        "msgtype": "m.text",
        "org.matrix.msc1767.text": "foo bar"
      }
    }
  },
  "type": "org.matrix.msc3381.poll.start"
}

Expected behavior

No response

Platform and versions

1. OS: GNU/Linux 7.1.1 (NixOS Unstable)
2. Browser: Chrome 149.0.7827.114
3. Sable version: 1.18.3
4. Matrix homeserver: bartoostveen.nl (Continuwuity 0.5.10)

Additional context

No response

[7w1]

Hi, we couldn’t manage to reproduce this in testing. Can you provide some more context?

Was this a poll created with a different client?
Did the crash occur during voting/after in ended?
Did it occur when other clients interacted with a sable poll?

Any details you can provide would be helpful since we didn’t manage to reproduce the issue in our dev room with the exact example event provided.

[7w1]

Or check if the random guess fixes in the linked PR ^^ solve the problem.

[nushea]

Additionally if the PR does not resolve the issue may you advise whether the issue might happen around the thing where you click the (x votes) next to the option?

[bartoostveen]

I'm sorry, did not notice the quick response, but yes this fixed it :)