Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve command output on timeout #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erkinalp
Copy link

This PR implements output preservation when commands time out, ensuring that any output collected before the timeout is still accessible to the user.

Changes:

  • Add partial_output attribute to CommandTimeoutError to store pre-timeout output
  • Modify timeout handling in BashSession._run_normal to capture output before timeout
  • Update BashSession.run to return partial output in BashObservation on timeout
  • Update documentation to reflect new timeout behavior

This improves the user experience by not losing potentially valuable partial output when commands time out.

Link to Devin run: https://app.devin.ai/sessions/e14f693390ed47ba87d12698d5834d08

Fixes #29

When a command times out, the system now preserves and returns any output
that was collected before the timeout occurred. This improves the user
experience by not losing potentially valuable partial output.

Changes:
- Add partial_output to CommandTimeoutError
- Capture and return partial output in timeout scenarios
- Update documentation to reflect new behavior

Fixes SWE-agent#29

Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit timeout should still return output collected so far
1 participant