Skip to content

Name pre pro arg #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2017
Merged

Name pre pro arg #101

merged 2 commits into from
Nov 15, 2017

Conversation

ablot
Copy link
Contributor

@ablot ablot commented Nov 14, 2017

Since using illumChans is more likely to be the default behaviour, I'd vote for keeping channelsToProcessoptional

@raacampbell
Copy link
Contributor

Thanks. Can you also update the changelog file when you make big changes like this so that when we eventually merge to master people will know what changed.

@raacampbell raacampbell merged commit f42d6f3 into SWC-Advanced-Microscopy:dev Nov 15, 2017
@ablot ablot deleted the namePreProArg branch March 16, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ablot @raacampbell