Don't put IDs in the DOM in createElement mode

SUpermin6u · Nov 4, 2015 · c193d1a · c193d1a
1 parent b80f676
commit c193d1a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/renderers/dom/client/ReactMount.js b/src/renderers/dom/client/ReactMount.js
@@ -175,12 +175,11 @@ function unmountComponentFromNode(instance, container) {
  * @internal
  */
 function hasNonRootReactChild(container) {
-  var rootElement = getReactRootElementInContainer(container);
-  return !!(
-    rootElement &&
-    internalGetID(rootElement) &&
-    !rootElement.hasAttribute(ROOT_ATTR_NAME)
-  );
+  var rootEl = getReactRootElementInContainer(container);
+  if (rootEl) {
+    var inst = ReactDOMComponentTree.getInstanceFromNode(rootEl);
+    return !!(inst && inst._nativeParent);
+  }
 }
 
 function getNativeRootInstanceInContainer(container) {

diff --git a/src/renderers/dom/shared/ReactDOMComponent.js b/src/renderers/dom/shared/ReactDOMComponent.js
@@ -665,7 +665,6 @@ ReactDOMComponent.Mixin = {
       if (!this._nativeParent) {
         DOMPropertyOperations.setAttributeForRoot(el);
       }
-      DOMPropertyOperations.setAttributeForID(el, this._domID);
       this._updateDOMProperties(null, props, transaction);
       var lazyTree = DOMLazyTree(el);
       this._createInitialChildren(transaction, props, context, lazyTree);

diff --git a/src/renderers/dom/shared/ReactDOMTextComponent.js b/src/renderers/dom/shared/ReactDOMTextComponent.js
@@ -97,7 +97,6 @@ assign(ReactDOMTextComponent.prototype, {
       var ownerDocument = nativeContainerInfo._ownerDocument;
       var el = ownerDocument.createElement('span');
       ReactDOMComponentTree.precacheNode(this, el);
-      DOMPropertyOperations.setAttributeForID(el, domID);
       var lazyTree = DOMLazyTree(el);
       DOMLazyTree.queueText(lazyTree, this._stringText);
       return lazyTree;