Suggest running ansible-lint #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarocarvajald
approved these changes
Feb 11, 2025
CONTRIBUTING.md
Outdated
| @@ -58,9 +58,9 @@ The project is composed by files in many different code languages: Terraform, An | |||
| * All code needs to be checked locally. As the repository contains different kinds of code (Terraform, Ansible, Python, Documentation, bash scripts), any PR need to be prepared in different way, accordingly to its content: | |||
| * Documentation: some of the Markdown files are tested for Markdown syntax and spelling. | |||
| * Python code: it is mostly important for the glue script code in `scripts/qesap`. The code is statically tested with pylint and flake8. These tests can be executed manually with `make static-py` or with `tox -e pylint`. Some unit testing are also associated with the qesap.py script. They can be executed with `tox` or using `make test`. | |||
| * Ansible code: code can be statically tested using `make static-ansible`. | |||
| * Ansible code: code can be statically tested using `make static-ansible`. It is also raccomanded to run `make static-ansible-lint` and fix at least warnings in the edited file (please consider that for the moment this target is not part of any github pipeline) | |||
There was a problem hiding this comment.
s/raccomanded/recommended/
|
LGTM except the typo Alvaro pointed out, thanks |
Add suggestion in CONTRIBUTING about PR preparation
mpagot
force-pushed
the
contribute_ansible_lint
branch
from
d584e32 to
6211a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.