feat(components/molecule/imageEditor): Add a preview mode to molecule/imageEditor to optimize image #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/imageEditor to optimize image
oegea
requested review from
andresin87,
arnau-rius,
kikoruiz,
midudev,
rmoralp and
sui-bot
as code owners
|
jordevo
reviewed
Aug 23, 2022
| MoleculeImageEditor.displayName = 'MoleculeImageEditor' | ||
| MoleculeImageEditor.propTypes = { | ||
| aspect: PropTypes.number, | ||
| previewOnlyMode: PropTypes.bool, |
Contributor
There was a problem hiding this comment.
Suggested change
| previewOnlyMode: PropTypes.bool, | |
| isPreviewMode: PropTypes.bool, |
or even
Suggested change
| previewOnlyMode: PropTypes.bool, | |
| isPreview: PropTypes.bool, |
given they're boolean props. What do you think...?
jordevo
approved these changes
Aug 23, 2022
AgonisticKatai
approved these changes
Aug 23, 2022
|
andresin87
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Molecule/ImageEditor
❓ AskTypes of changes
Description, Motivation and Context
ImageEditor is currently calculating a new image every time the user makes zoom or rotates an image. Which, with a normal use, could happen between 50 and 100 times just by sliding the zoom or rotation slide.
This is causing a bad performance. Additionally, as we don't know which is the final calculated image, we're not sure when the
savebutton of our web-app can be enabled to finish the process.To solve this problematic, this proposal debounces the execution of some critical functions, to ensure that image is calculate just when needed.
Co-authored with @andresin87
Screenshots - Animations
There aren't visual changes.