Remove id uniqueness constraint #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is kind of a nit (ok 100% a nit) but now that the uniqueness keys are gone you can also remove the namespace alias mappings to schemas that aren't actually used. The only reason they were added was for that key. Aside from that this looks good. I'll let @gtback merge since he's your "buddy". |
|
@johnwunder, wow good catch! I hadn't thought to remove those at all. It should be all set now unless Travis complains. |
|
Ha, the only reason I caught that is because I had to add them in the first place. |
|
@gtback, I think this is all set to merge. Take a look and let me know if anything seems off. |
|
Looks good to me. It's going to further break #295, but that should be easy to resolve. |
gtback
added a commit
that referenced
this pull request
Apr 13, 2015
Remove id uniqueness constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #236. Removed
<xs:unique>constraint on STIX schemas.