Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS⚠️ ◾ Add question to log when query fails #702

Merged
merged 1 commit into from
May 20, 2024
Merged

XS⚠️ ◾ Add question to log when query fails #702

merged 1 commit into from
May 20, 2024

Conversation

AttackOnMorty
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Resolves #670

  1. What was changed?
  • Added question to log
  1. Did you do pair or mob programming?

No

@github-actions GitHub Actions
Copy link

PR Metrics

✔ Thanks for keeping your pull request small.
⚠️ Consider adding additional tests.

Lines
Product Code 8
Test Code -
Subtotal 8
Ignored Code -
Total 8

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Add question to log when query fails XS⚠️ ◾ Add question to log when query fails May 20, 2024
AttackOnMorty
AttackOnMorty commented May 20, 2024
View reviewed changes
bots/employee-finder/src/SSW.SophieBot/Integration/SophieBotAdapter.cs
{{"Bot exception caught in", $"{nameof(SophieBotAdapter)} - {nameof(OnTurnError)}"}};
{
{ "Bot exception caught in", $"{nameof(SophieBotAdapter)} - {nameof(OnTurnError)}" },
{ "Question", turnContext.Activity.Text },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. We can get the question from turnContext.Activity.Text

image

@AttackOnMorty AttackOnMorty merged commit b5eefe8 into main May 20, 2024
1 check passed
@AttackOnMorty AttackOnMorty deleted the 670--ensure-important-errors-are-being-logged branch May 20, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidier jimmidier jimmidier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Ensure important errors are being logged
2 participants
@AttackOnMorty @jimmidier