Skip to content

Commit

Permalink
tests: remove multihost basic tests
Browse files Browse the repository at this point in the history
* test_ifp.py test are now convered in system/test_infopipe.py
* test_kcm.py test are now covered in system/test_kdm.py and
  authselect/system/test_sssd.py , the functional credential delegation
** a functional test has been added to the test plan
* test_ldapapi.py tests are low priority with a larger effort to move.
** test configures ldap, using the 389 slapd file for it's URI, this
test can only be performed on a server and does not offer much value.
this test has been added to the test plan and will be re-implemented if
approved.

Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Reviewed-by: Scott Poore <spoore@redhat.com>

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
  • Loading branch information
Dan Lavu authored and jakub-vavra-cz committed Sep 5, 2024
1 parent a03b4bd commit c1f81b3
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 1,543 deletions.
117 changes: 1 addition & 116 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,120 +134,6 @@ jobs:
path: |
./sssd/ci-build-debug/*.valgrind.log
multihost:
needs: [prepare, build]
strategy:
fail-fast: false
matrix:
tag: ${{ fromJson(needs.prepare.outputs.matrix).multihost }}
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Checkout sssd repository
uses: actions/checkout@v3
with:
path: sssd

- name: Setup containers
uses: SSSD/sssd-ci-containers/actions/setup@master
with:
path: sssd-ci-containers
tag: ${{ matrix.tag }}
limit: dns client
override: |
services:
client:
image: ${REGISTRY}/ci-client-devel:${TAG}
shm_size: 4G
tmpfs:
- /dev/shm
volumes:
- ../sssd:/sssd:rw
- name: Build SSSD on the client
uses: SSSD/sssd-ci-containers/actions/exec@master
with:
log-file: multihost-build.log
working-directory: /sssd
script: |
#!/bin/bash
set -ex
./contrib/ci/run --deps-only
autoreconf -if
mkdir -p /dev/shm/sssd
pushd /dev/shm/sssd
/sssd/configure --enable-silent-rules
make rpms
- name: Install SSSD on the client
uses: SSSD/sssd-ci-containers/actions/exec@master
with:
log-file: multihost-install.log
user: root
script: |
#!/bin/bash
set -ex
dnf remove -y --noautoremove sssd\*
dnf install -y /dev/shm/sssd/rpmbuild/RPMS/*/*.rpm
rm -fr /dev/shm/sssd
- name: Install multihost tests dependencies
shell: bash
run: |
set -ex
sudo apt-get update
# Install certutil and dependencies for python-ldap
sudo apt-get install -y libnss3-tools libsasl2-dev python3-dev libldap2-dev libssl-dev
# Virtualenv
pip3 install virtualenv
python3 -m venv .venv
source .venv/bin/activate
# Install multihost tests requirements
pip3 install -r ./sssd/src/tests/multihost/requirements.txt
- name: Create multihost configuration
uses: DamianReeves/write-file-action@41569a7dac64c252caacca7bceefe28b70b38db1
with:
path: mhc.yml
write-mode: overwrite
contents: |
root_password: 'Secret123'
domains:
- name: tier0.tests
type: sssd
hosts:
- name: client
external_hostname: client.test
role: master
- name: Run basic multihost tests
run: |
set -ex -o pipefail
source .venv/bin/activate
export PYTHONPATH="${PYTHONPATH}:$(realpath ./sssd/src/tests/multihost)"
pytest -s --multihost-config=./mhc.yml ./sssd/src/tests/multihost/basic |& tee multihost-pytest.log
- name: Upload artifacts
if: always()
uses: actions/upload-artifact@v3
with:
if-no-files-found: ignore
name: ${{ matrix.tag }}-multihost
path: |
sssd/ci-install-deps.log
multihost-build.log
multihost-install.log
multihost-pytest.log
system:
needs: [prepare, build]
strategy:
Expand Down Expand Up @@ -376,12 +262,11 @@ jobs:
name: All tests are successful
if: ${{ always() }}
runs-on: ubuntu-latest
needs: [build, intgcheck, multihost, system]
needs: [build, intgcheck, system]
steps:
- name: Fail on failure
if: |
needs.build.result != 'success'
|| needs.intgcheck.result != 'success'
|| needs.multihost.result != 'success'
|| needs.system.result != 'success'
run: exit 1
Loading

0 comments on commit c1f81b3

Please sign in to comment.