-
Notifications
You must be signed in to change notification settings - Fork 15
More invariants #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More invariants #90
Conversation
|
This is ready for review. I will have another look at the failing builds. I am using 8.19 locally, so it is strange that it fails in the pipeline. |
|
Thanks! These are nice simplifications. |
I think that it is the math-comp version causing problems. It might also be time to stop supporting Coq 8.18-8.19 and some older math-comp versions. |
|
Yes, I think it's fine to drop support for them. I guess it will break the jasmin part, which was broken already. |
|
We already have a branch of Hax that works with Rocq 9.0. |
|
Feel free to drop the other versions then, if it simplifies things... |
|
I made an ugly fix that maybe applies a rewrite rule, so that it both works with the flake (that I am using locally) and the pipeline. |
|
Build succeeded. It may be better to use something like |
|
@MarkusKL The comment about versions was just a general comment and not related to this issue. The changes look good to me, so let's merge. |
Improvements made by this PR:
rel_appas a general relation invariant over any number of sided locations. Closes Generalize relations between locations in the invariant. #71couple_lhs,coupls_rhs,triple_rhs.single_lhs,single_rhs,triple_lhs,couple_cross`.ssprove_invariantwhen locations in a relation have not been put and/or remembered.TODO: