Add 'Clear Inventory' Form #11
Conversation
Adding Clear Inventory Form to let refresh existing Inventory at the start of semester by Mess System Managers themselves. Till now they call us to do it from MySql Workbench. I hope it will help.
| Catch ex As Exception | ||
| MsgBox("Error Occured ! Please contact SSMS Tech Team !!") | ||
| MsgBox(ex.Message.ToString) | ||
|
|
There was a problem hiding this comment.
Good that you have added a try-catch here but this error handling message actually does not help much. Not even for us developers while debugging the problem. I am not picking on this specific message, but most of the messages all over the code are like this.
I think a simple but related message in MsgBox would be much better here.
For a better way for future, I suggest that we should add a logging interface (to log to a log file), where not only the exceptions but all the operations are also logged with their Timestamp so that it becomes simpler to debug stuff (and all the other MsgBox msgs also can be changed to be simple but related).
It would be great if you could look into it.
There was a problem hiding this comment.
Should I remove Try- Catch in this file? or leave it ?
Yes, I will look into logging interface
There was a problem hiding this comment.
No. You should obviously keep it. I just suggested that you could improve the message may be.
There was a problem hiding this comment.
Shall we merge this patch to main branch?
There was a problem hiding this comment.
I have not tested it; I suppose @AAP67 can take a look and merge it after testing.
Adding Clear Inventory Form to let refresh existing Inventory at the start of semester by Mess System Managers themselves.
Till now they call us to do it from MySql Workbench.
I hope it will help.