Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FindSQLiteCpp.cmake #293

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Remove FindSQLiteCpp.cmake #293

merged 1 commit into from
Aug 19, 2020

Conversation

sum01
Copy link
Contributor

@sum01 sum01 commented Aug 18, 2020

It's not needed since the automatically generated file
SQLiteCppConfig.cmake already exists.

Added a small section to the README to explain how it can be used when
this library is installed to the system.

Fixes #283

@SRombauts
Copy link
Owner

Hello, thanks for your work!
Have you seen its failing ci builds?
It's just because the file is still used in the CMakeLists.txt

Cannot find source file:
    cmake/FindSQLiteCpp.cmake

It's not needed since the automatically generated file
SQLiteCppConfig.cmake already exists.

Added a small section to the README to explain how it can be used when
this library is installed to the system.

Fixes SRombauts#283
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 72c4983 on sum01:fix_283 into cc2e488 on SRombauts:master.

@sum01
Copy link
Contributor Author

sum01 commented Aug 19, 2020

Should be all good. Just forgot to remove that line like you said.

@SRombauts SRombauts self-assigned this Aug 19, 2020
@SRombauts SRombauts merged commit a6bb7bc into SRombauts:master Aug 19, 2020
@SRombauts
Copy link
Owner

Thanks again!

@sum01 sum01 deleted the fix_283 branch August 19, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete FindSQLiteCpp.cmake
3 participants