Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly find and link against system sqlite library #229

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Explicitly find and link against system sqlite library #229

merged 1 commit into from
Dec 24, 2019

Conversation

xvitaly
Copy link
Contributor

@xvitaly xvitaly commented Nov 25, 2019 •
edited
Loading

Explicitly find and link against system sqlite library when built with -SQLITECPP_INTERNAL_SQLITE=OFF.

This will fix -as-needed linker issue:

sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_text
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_close
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_int
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_reset
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_int
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_total_changes
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_clear_bindings
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_open_v2
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_bytes
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_null
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_exec
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_extended_errcode
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_backup_step
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_free
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_backup_remaining
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_db_config
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_double
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_backup_init
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_int64
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_int64
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_finalize
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_type
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_errcode
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_changes
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_text
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_origin_name
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_step
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_backup_finish
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_count
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_create_function_v2
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_errstr
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_errmsg
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_load_extension
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_name
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_blob
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_parameter_index
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_libversion
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_prepare_v2
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_backup_pagecount
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_libversion_number
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_busy_timeout
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_column_double
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_blob
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_bind_parameter_count
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_open
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_expanded_sql
sqlitecpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSQLiteCpp.so.0
sqlite3_last_insert_rowid

@coveralls
Copy link

coveralls commented Nov 25, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 96.586% when pulling 395c047 on xvitaly:systemsqlite into 5b5ca14 on SRombauts:master.

@xvitaly
Explicitly find and link against system sqlite library.
395c047 
Signed-off-by: Vitaly Zaitsev <vitaly@easycoding.org>
@SRombauts SRombauts self-assigned this Dec 24, 2019
@SRombauts SRombauts merged commit 11fab0f into SRombauts:master Dec 24, 2019
@SRombauts
Copy link
Owner

Thank you @xvitaly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SRombauts SRombauts

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xvitaly @coveralls @SRombauts