Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix set sqlite3 propertie #212

Merged
merged 1 commit into from
Aug 26, 2019
Merged

fix set sqlite3 propertie #212

merged 1 commit into from
Aug 26, 2019

Conversation

jiangzhuti
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.586% when pulling 7c2c62a on jiangzhuti:jiangzhuti-patch-1 into c1ab707 on SRombauts:master.

@SRombauts SRombauts self-assigned this Aug 25, 2019
@SRombauts
Copy link
Owner

Hi!

Thanks for this, but can you explain the logic? I think we might actually want both sqlite3 and SQLiteCpp as dynamic libraries, depending on the use cases?

@jiangzhuti
Copy link
Contributor Author

jiangzhuti commented Aug 26, 2019 •
edited
Loading

Hi!

Thanks for this, but can you explain the logic? I think we might actually want both sqlite3 and SQLiteCpp as dynamic libraries, depending on the use cases?

https://github.com/SRombauts/SQLiteCpp/blob/master/CMakeLists.txt#L192 VS https://github.com/SRombauts/SQLiteCpp/blob/master/sqlite3/CMakeLists.txt#L15

@SRombauts SRombauts merged commit 629497e into SRombauts:master Aug 26, 2019
@SRombauts
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SRombauts SRombauts

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangzhuti @coveralls @SRombauts