fix(vmware): allow deletion of VirtualDisk #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, nice catch. Thanks! Could you just use formatter like golines, to avoid golangci long lines rule (120 chars max). Something like: go install github.com/segmentio/golines@latest
golines ./internal/netbox/inventory/delete_items.go |
n-rodriguez
force-pushed
the
fix/delete-virtual-disk
branch
from
773b3e2 to
53aca76
Compare
|
@bl4ko done! |
bl4ko
pushed a commit
that referenced
this pull request
Mar 5, 2025
* chore(k8s): Replace version in k8s manifests * fix(vmware): allow deletion of VirtualDisk --------- Co-authored-by: src-csm <199741225+src-csm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!