Merge pull request dataplat#956 from sqlcollaborative/development

small fix for PS v4 and below
SQLadmin · Mar 15, 2017 · e11c8cb · e11c8cb
2 parents 081f7b8 + f908381
commit e11c8cb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/dbatools.psd1 b/dbatools.psd1
@@ -11,7 +11,7 @@
 	RootModule = 'dbatools.psm1'
 
 	# Version number of this module.
-	ModuleVersion = '0.8.941'
+	ModuleVersion = '0.8.942'
 
 	# ID used to uniquely identify this module
 	GUID = '9d139310-ce45-41ce-8e8b-d76335aa1789'

diff --git a/functions/Find-DbaCommand.ps1 b/functions/Find-DbaCommand.ps1
@@ -182,7 +182,7 @@ Finds all commands searching the entire help for "snapshot", rebuilding the inde
 			Write-Verbose "Rebuild done in $($swrebuild.Elapsedmilliseconds)ms"
 
 		}
-		$consolidated = Get-Content $idxfile | ConvertFrom-Json
+		$consolidated = Get-Content -Raw $idxfile | ConvertFrom-Json
 		$result = $consolidated
 		if ($Pattern.length -gt 0)
 		{

diff --git a/functions/Get-DbaSqlBuildReference.ps1 b/functions/Get-DbaSqlBuildReference.ps1
@@ -68,7 +68,7 @@ Integrate with other commandlets to have builds checked for all your registered
 				if(!(Test-Path $writable_idxfile)) {
 					Copy-Item $orig_idxfile $writable_idxfile
 				}
-				return (Get-Content $writable_idxfile)
+				return (Get-Content -Raw $writable_idxfile)
 			}
 		}
 

diff --git a/internal/Select-DefaultView.ps1 b/internal/Select-DefaultView.ps1
@@ -46,8 +46,8 @@ Function Select-DefaultView
 					if ($p -like "* as *")
 					{
 						$old, $new = $p -isplit " as "
-
-						Add-Member -InputObject $inputobject -MemberType AliasProperty -Name $new -Value $old -Force -ErrorAction SilentlyContinue
+						# Do not be tempted to not pipe here
+						$inputobject | Add-Member -MemberType AliasProperty -Name $new -Value $old -Force -ErrorAction SilentlyContinue
 						$newproperty += $new
 					}
 					else
@@ -63,7 +63,8 @@ Function Select-DefaultView
 
 		$standardmembers = [System.Management.Automation.PSMemberInfo[]]@($defaultset)
 
-		Add-Member -InputObject $inputobject -MemberType MemberSet -Name PSStandardMembers -Value $standardmembers -Force -ErrorAction SilentlyContinue
+		# Do not be tempted to not pipe here
+		$inputobject | Add-Member -MemberType MemberSet -Name PSStandardMembers -Value $standardmembers -Force -ErrorAction SilentlyContinue
 
 		$inputobject
 	}