Skip to content

SRENEW-2465 | fix to allow new kustomizations #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

SRENEW-2465 | fix to allow new kustomizations #3

merged 2 commits into from
Nov 13, 2024

Conversation

HarryGogonis
Copy link
Contributor

@HarryGogonis HarryGogonis commented Nov 13, 2024 •
edited
Loading

Fixes an unhandeled error that happens when creating a new Kustomization that did not exist in git history

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Comparing testdata/prod

Comparing testdata/prod/helm.toolkit.fluxcd.io_v2_helmrelease_testapp.yaml

@@ -10,7 +10,8 @@
         kind: GitRepository
         name: gitops
   interval: 1h
   releaseName: testapp
   values:
     deployment:
       useServiceAccount: false
+    foo: true

Comparing testdata/stage

Comparing testdata/stage/helm.toolkit.fluxcd.io_v2_helmrelease_testapp.yaml

@@ -10,7 +10,8 @@
         kind: GitRepository
         name: gitops
   interval: 1h
   releaseName: testapp
   values:
     deployment:
       useServiceAccount: true
+    foo: true

Comparing testdata/new

file list

@@ -0,0 +1 @@
+helm.toolkit.fluxcd.io_v2_helmrelease_testapp.yaml

@HarryGogonis HarryGogonis force-pushed the SRENEW-2465 branch 3 times, most recently from 1cd4793 to 8bf4a4e Compare November 13, 2024 15:54
@HarryGogonis HarryGogonis changed the title WIP: new folders SRENEW-2465 | fix to allow new kustomizations Nov 13, 2024
@HarryGogonis HarryGogonis force-pushed the SRENEW-2465 branch 7 times, most recently from e48010b to 9657452 Compare November 13, 2024 16:25
@HarryGogonis HarryGogonis marked this pull request as ready for review November 13, 2024 16:53
jasonreevessp
jasonreevessp approved these changes Nov 13, 2024
View reviewed changes
Copy link

@jasonreevessp jasonreevessp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@HarryGogonis HarryGogonis merged commit df4080d into main Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonreevessp jasonreevessp jasonreevessp approved these changes

@guitarislife87 guitarislife87 Awaiting requested review from guitarislife87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarryGogonis @jasonreevessp