Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove big marks from read count column #117

Merged
merged 1 commit into from
May 3, 2023
Merged

Remove big marks from read count column #117

merged 1 commit into from
May 3, 2023

Conversation

alexhbnr
Copy link
Contributor

@alexhbnr alexhbnr commented May 3, 2023

Explicitly removes the commas in the column read_count returned by ENA to allow the conversion into an integer column.

Closes issue #116.

@alexhbnr alexhbnr requested a review from maxibor May 3, 2023 14:19
maxibor
maxibor approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@maxibor maxibor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted !
That'll be yet another patch release ;)
I didn't catch it because it only came with strong type enforcement of the columns, and I wrote the demo just before.

@maxibor maxibor merged commit 50f97ed into SPAAM-community:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxibor maxibor maxibor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexhbnr @maxibor