Update readme with run instructions #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigomafrarios
approved these changes
May 16, 2024
edmolima
approved these changes
May 16, 2024
jardelmitermayer
approved these changes
May 16, 2024
Comment on lines
+108
to
+117
| ### Contribuindo | ||
|
|
||
| 1. Faça suas alterações; | ||
| 2. Rode os testes com `npm test`; | ||
| 3. Rode o lint com `npm run lint`; | ||
| 4. Crie um branch com o git `git checkout -b nomedobranch`; | ||
| 5. Faça um commit com `git commit`; | ||
| 6. Faça um push para o seu repositório com `git push`; | ||
| 7. [Sincronize seu repositório](#sincronizando); | ||
| 8. Abra um pull request. |
There was a problem hiding this comment.
Será que já não vale criar um CONTRIBUTING.md com as instruções e também com as definições de boas práticas?
There was a problem hiding this comment.
Vale. Um passo de cada vez. :)
marcieltorres
approved these changes
May 16, 2024
rodrigooler
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coloquei o que é necessário pra rodar a app, incluindo o banco, que estava faltando, e também como contribuir de volta.