Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7647 [DEMIS2SORMAS] Introduce a messages content search field #11776

Merged
merged 2 commits into from
Apr 13, 2023
Merged

#7647 [DEMIS2SORMAS] Introduce a messages content search field #11776

merged 2 commits into from
Apr 13, 2023

Conversation

leventegal-she
Copy link
Contributor

@leventegal-she leventegal-she commented Apr 3, 2023 •
edited
Loading

Fixes #7647

Added explanation on the issue #7647 (comment)

MateStrysewske
MateStrysewske requested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@MateStrysewske MateStrysewske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing :)

ChristopherRiedel
ChristopherRiedel approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@ChristopherRiedel ChristopherRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the failing tests everything looks good

@sormas-vitagroup
Copy link
Contributor

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=11776

MateStrysewske
MateStrysewske requested changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@MateStrysewske MateStrysewske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can only look at the code and not test it; code looks good, however, build pipeline still fails because of linting.

@leventegal-she
Copy link
Contributor Author

Can only look at the code and not test it; code looks good, however, build pipeline still fails because of linting.

The lint is related to sql: No dialect was specified. Looks to be a configuration issue of the linter

@MateStrysewske MateStrysewske self-requested a review April 6, 2023 08:42
@leventegal-she leventegal-she merged commit 3e23ad8 into development Apr 13, 2023
@leventegal-she leventegal-she deleted the feature-7647_external_message_content_filter branch April 13, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherRiedel ChristopherRiedel ChristopherRiedel approved these changes

@MateStrysewske MateStrysewske MateStrysewske approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEMIS2SORMAS] Introduce a messages content search field [3]
4 participants
@leventegal-she @sormas-vitagroup @MateStrysewske @ChristopherRiedel