Skip to content

Conversation

@fupelaqu
Copy link
Contributor

@fupelaqu fupelaqu commented Dec 9, 2022

No description provided.

…n guardian api + add typed notification behaviors and handlers + add mock server for apns
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 25.17% // Head: 66.21% // Increases project coverage by +41.03% 🎉

Coverage data is based on head (c1349f9) compared to base (2c2b565).
Patch coverage: 77.98% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
+ Coverage   25.17%   66.21%   +41.03%     
===========================================
  Files          17       28       +11     
  Lines         556      595       +39     
===========================================
+ Hits          140      394      +254     
+ Misses        416      201      -215     
Flag Coverage Δ
unittests 66.21% <77.98%> (+41.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...app/softnetwork/notification/message/package.scala 100.00% <ø> (ø)
...tnetwork/notification/api/NotificationServer.scala 60.00% <ø> (+3.75%) ⬆️
.../notification/launch/NotificationApplication.scala 0.00% <0.00%> (ø)
...ork/notification/launch/NotificationGuardian.scala 61.53% <50.00%> (+1.53%) ⬆️
...app/softnetwork/notification/spi/FcmProvider.scala 70.73% <58.82%> (+70.73%) ⬆️
...softnetwork/notification/spi/SMSModeProvider.scala 43.08% <60.00%> (+43.08%) ⬆️
...ation/persistence/typed/NotificationBehavior.scala 64.96% <65.00%> (+7.21%) ⬆️
.../persistence/typed/MailNotificationsBehavior.scala 66.66% <66.66%> (ø)
.../persistence/typed/PushNotificationsBehavior.scala 80.00% <80.00%> (ø)
...pp/softnetwork/notification/spi/ApnsProvider.scala 84.61% <83.33%> (+84.61%) ⬆️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fupelaqu fupelaqu merged commit 91acb08 into main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants