Skip to content

Use an exception class when raising an exception #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimEvens merged 1 commit into from
Mar 22, 2017
Merged

Use an exception class when raising an exception #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/openbmp/api/parsed/message/Base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def parse(self, version, data):
:return: True if error, False if no errors
"""
if not data.strip(): # If "data" is not string, throws error.
raise "Invalid data!", data
raise ValueError("Invalid data!", data)

self.spec_version = float(version)

Expand Down
4 changes: 2 additions & 2 deletions src/openbmp/api/parsed/message/Message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def __init__(self, data):
"""

if not data.strip(): # If "data" is not string, throws error.
raise "Invalid data!", data
raise ValueError("Invalid data!", data)

self.version = float()
self.type = str()
Expand Down Expand Up @@ -101,4 +101,4 @@ def getContentPos(self):
return self.content_pos

def getContent(self):
return self.content
return self.content