Skip to content

Merge Request #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimEvens merged 56 commits into from
Sep 20, 2016
Merged

Merge Request #1

TimEvens merged 56 commits into from
Sep 20, 2016

Conversation

@omerpalaz
Copy link
Contributor

@omerpalaz omerpalaz commented Sep 2, 2016

No description provided.

omerpalaz added 20 commits August 22, 2016 14:58
@omerpalaz
First test commit.
c32b5f8
@omerpalaz
README.md file update.
b3fdf36
@omerpalaz
First test commit.
b9a2ecc
@omerpalaz
Message class is added.
9bbdb26
@omerpalaz
"LsPrefix" message type is added.
7bb2d52
@omerpalaz
"LsLink" message type class is added.
1689230
@omerpalaz
"LsNode" message type class is added.
fe98aaa
@omerpalaz
"LsNode" message type class is added.
59786ab
@omerpalaz
"BmpStat" and "BaseAttribute" message type class is added.
f7177c3
@omerpalaz
"Peer" message type class is added.
023ec0c
@omerpalaz
"Collector" and "Router" message type class is added.
2dba6be
@omerpalaz
- "Example_Kafka_Consumer" is added for test purposes.
2a55330 
- Message type classes are put in folder "Message_Types"
- "Message" class is debugged.
@omerpalaz
- Parser in "Base" class completed.
283eead
@omerpalaz
- 'toJson' and 'toJsonPretty' functions are implemented.
7264dc1
@omerpalaz
- 'FieldProcessors' class is added.
7aff51a 
- 'Kafka_Consumer' class is added to test the api.
@omerpalaz
- Comments are added to the code.
6d6e847
@omerpalaz
- API is a package to use now.
041c099
@omerpalaz
- README.md file is completed.
d6dae23 
- Documentation of "getMapRow()" is added to the class 'Base'
@omerpalaz
README.md is updated.
0675318
@omerpalaz
- Message type classes are debugged.
d0e16a5
TimEvens
TimEvens reviewed Sep 3, 2016
View reviewed changes
.idea/vcs.xml Outdated
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

@TimEvens TimEvens Sep 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the .idea directory. Can you also add a .gitignore similar to the other projects to prevent .idea and other unwanted files in the repo?

Copy link
Contributor Author

@omerpalaz omerpalaz Sep 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ".idea" directory is removed.
  • ".gitignore" is added to the project repo.

@TimEvens
Copy link
Contributor

TimEvens commented Sep 7, 2016

A few changes:

  • setup.py is empty. It should be similar to what you see in the other python modules. It needs to include the install for the openbmp items only.
  • README should be updated to include install steps, including wheel.
  • You are missing init.py under openbmp/, openbmp/api/, and openbmp/api/parsed. You need __init__.py under each module directory, otherwise import fails with no module found.
  • examples/log_consumer.py is not importing the library correctly. Should be openbmp.api.parsed.message. The __all__ variable is not defined in __init__.py , so it's not importing the needed modules. Define all so that import * works correctly.
  • When using import * you need to use .. For example, Message.Message(), not Message(). Alternatively, you can import each module/class (eg. from openbmp.api.parsed.message.Message import Message).

@omerpalaz
- BaseAttribute is compatible with java codebase.
d9e2bf1 
- BmpStat is compatible with java codebase.
@omerpalaz
- Collector class is compatible with java codebase.
2572309
@omerpalaz
- LsLink class is compatible with java codebase.
68de38f
@omerpalaz
- LsNode class is compatible with java codebase.
90addc8
@omerpalaz
- LsPrefix class is compatible with java codebase.
84de186
@omerpalaz
- Peer class is compatible with java codebase.
b553fa6
@omerpalaz
- UnicastPrefix class is compatible with java codebase.
170e3cd
@omerpalaz
- setup.py is created.
b9bfdc6
@omerpalaz
- README.md is updated with import of classes.
c2e37fe 
- setup.py is updated.
@omerpalaz
- README.md is updated with import of classes.
cbcfc65
@omerpalaz
- README.md is updated with installation instructions.
49bb29c 
 - Project directory structure fixed.
@omerpalaz
- README.md is updated with message type names.
b307ce4
@omerpalaz
- README.md is updated.
bcbd0cd
@omerpalaz
- setup.py is updated with correct license info.
9d68c60 
- LICENSE file is added to the project.
@omerpalaz
- MsgBusFields uses objects instead of dict directly in order to supp…
a2aaeb1 
…ort getName() and getDefaultValue() functions.

- config.yaml is added to example directory.
- log_consumer.py is updated to show timestamp, message type and version.
@omerpalaz
- README.md file is updated for installation instructions.
f21dd27
@omerpalaz
- log_consumer is updated to show "Received Message" text in logs.
e0645d3
@omerpalaz
- log_consumer is updated to show "Received Message" text in logs.
113b6e7
@omerpalaz omerpalaz closed this Sep 19, 2016
@omerpalaz omerpalaz reopened this Sep 19, 2016
@TimEvens TimEvens merged commit 39a9eda into SNAS:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omerpalaz @TimEvens