Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/query parameters ignored for path composition #71

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Fix/query parameters ignored for path composition #71

merged 4 commits into from
Nov 13, 2023

Conversation

Giuliopime
Copy link
Contributor

No description provided.

@Giuliopime
Copy link
Contributor Author

Uhm too many recursive calls? Ignorable?

@Giuliopime
Copy link
Contributor Author

This wont fix the recursive issue but I figured it was coherent with the rest of the code

@SMILEY4
Copy link
Owner

SMILEY4 commented Nov 13, 2023

Thank you for the pr. Looks good 👍
Imho, the detekt-warning can be ignored here. Could we supress it for the method so we have green checks ?

@SMILEY4 SMILEY4 merged commit 6ae057d into SMILEY4:develop Nov 13, 2023
2 checks passed
@Giuliopime Giuliopime deleted the fix/query-parameters-ignored-for-path-composition branch November 13, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuliopime @SMILEY4