Skip to content

search function options shouldn't be a partial type from SearchOptions #73

Closed
@mlbonniec

Description

@mlbonniec

Brief Description

Currently the options parameter of the search function is of type Partial<SearchOptions>.
All properties have a default value.
As searchItems and searchText are mandatory for the search, they shouldn't be optional.

The options type should be a type with keys, include, exact optional, and searchItems, searchText required.

If that's okay, I can make a PR myself.

Environment

  • @smakss/search version: 2.0.1
  • node.js version: v21.7.1
  • npm version: v10.5.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions