Skip to content
This repository was archived by the owner on Jul 12, 2026. It is now read-only.

Claude/refactor modernize 2025 011 cv1sad p rrxj5s p hj wp7 wa - #7

Merged
SL-Mar merged 2 commits into
refactor/modernize-2025from
claude/refactor-modernize-2025-011CV1sadPRrxj5sPHjWp7Wa
Nov 11, 2025
Merged

Claude/refactor modernize 2025 011 cv1sad p rrxj5s p hj wp7 wa#7
SL-Mar merged 2 commits into
refactor/modernize-2025from
claude/refactor-modernize-2025-011CV1sadPRrxj5sPHjWp7Wa

Conversation

@SL-Mar

@SL-Mar SL-Mar commented Nov 11, 2025

Copy link
Copy Markdown
Owner

Merging review with previous

## Security Enhancements
- Add missing `requests` import in utils.py (CRITICAL BUG FIX)
- Implement URL validation before webbrowser.open() calls
- Add validate_url() function to check URL safety
- Replace hardcoded email with UNPAYWALL_EMAIL environment variable

## Configuration
- Create .env.example documenting all environment variables
- Add support for UNPAYWALL_EMAIL configuration

## Changes
- quantcli/utils.py: Add requests import, urlparse, validate_url()
- quantcli/cli.py: Add URL validation to browser operations
- quantcli/gui.py: Add URL validation to browser operations
- .env.example: Document all configurable environment variables

These changes improve security by validating all URLs before opening
them in the browser and fix the critical missing requests import bug.
- Installation verification steps
- Security testing procedures
- Example workflows
- Troubleshooting guide
- Complete CLI command reference
@SL-Mar
SL-Mar merged commit 9a5f173 into refactor/modernize-2025 Nov 11, 2025
@SL-Mar
SL-Mar deleted the claude/refactor-modernize-2025-011CV1sadPRrxj5sPHjWp7Wa branch November 11, 2025 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants